Update tests to add missing assert and = which check permission for LiveViews.

test/decentralised_book_index_web/live/live_views_permission_for_other_servers_data_test.exs

@@ -0,0 +1,91 @@
+defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsForOtherServersDataTest do
+  use DecentralisedBookIndexWeb.LiveCase, async: true
+
+  alias DecentralisedBookIndex.TestEndpoints
+  @test_server_endpoint TestEndpoints.test_api_endpoint()
+
+  setup do
+    moderator = generate(user(role: :moderator))
+    admin = generate(user(role: :admin))
+    server = generate(dbi_server(url: @test_server_endpoint))
+
+    %{
+      server: server,
+      moderator: moderator,
+      admin: admin,
+      users: [moderator, admin]
+    }
+  end
+
+  describe "Book Edit /books/:id/edit" do
+    setup %{server: server} do
+      %{book: generate(book(dbi_server_id: server.id))}
+    end
+
+    test "can't edit other servers' data", %{conn: conn, users: users, book: book} do
+      for user <- users do
+        redirect_url = "/books/#{book.id}"
+
+        assert {:error,
+                {:redirect,
+                 %{flash: %{"error" => "Can't edit other server's data!"}, to: ^redirect_url}}} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/books/#{book.id}/edit")
+      end
+    end
+  end
+
+  describe "Author Edit /authors/:id/edit" do
+    setup %{server: server} do
+      %{author: generate(author(dbi_server_id: server.id))}
+    end
+
+    test "can't edit other servers' data", %{conn: conn, users: users, author: author} do
+      for user <- users do
+        redirect_url = "/authors/#{author.id}"
+
+        assert {:error,
+                {:redirect,
+                 %{flash: %{"error" => "Can't edit other server's data!"}, to: ^redirect_url}}} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/authors/#{author.id}/edit")
+      end
+    end
+  end
+
+  describe "Publisher Edit /publishers/:id/edit" do
+    setup %{server: server} do
+      %{publisher: generate(publisher(dbi_server_id: server.id))}
+    end
+
+    test "can't edit other servers' data", %{conn: conn, admin: admin, publisher: publisher} do
+      for user <- [admin] do
+        redirect_url = "/publishers/#{publisher.id}"
+
+        assert {:error,
+                {:redirect,
+                 %{flash: %{"error" => "Can't edit other server's data!"}, to: ^redirect_url}}} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/publishers/#{publisher.id}/edit")
+      end
+    end
+  end
+
+  describe "Server Edit /servers/:id/edit" do
+    setup %{server: server} do
+      %{dbi_server: generate(dbi_server(dbi_server_id: server.id))}
+    end
+
+    test "can edit other servers' data", %{conn: conn, admin: admin, dbi_server: dbi_server} do
+      for user <- [admin] do
+        assert {:ok, _view, _html} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/servers/#{dbi_server.id}/edit")
+      end
+    end
+  end
+end

test/decentralised_book_index_web/live/live_views_permission_test.exs

@@ -47,11 +47,10 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
   describe "Book Edit /books/:id/new" do
     test "can't be accessed by regular user", %{conn: conn, user: user} do
       for user <- [nil, user] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
-
-        conn
-        |> log_in_user(user)
-        |> live("/books/new")
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/books/new")
       end
     end
 
@@ -78,11 +77,10 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
 
     test "can't be accessed by regular user", %{conn: conn, user: user, book: book} do
       for user <- [nil, user] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
-
-        conn
-        |> log_in_user(user)
-        |> live("/books/#{book.id}/edit")
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/books/#{book.id}/edit")
       end
     end
 
@@ -136,11 +134,10 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
   describe "Author Edit /authors/:id/new" do
     test "can't be accessed by regular user", %{conn: conn, user: user} do
       for user <- [nil, user] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
-
-        conn
-        |> log_in_user(user)
-        |> live("/authors/new")
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/authors/new")
       end
     end
 
@@ -167,11 +164,10 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
 
     test "can't be accessed by regular user", %{conn: conn, user: user, author: author} do
       for user <- [nil, user] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
-
-        conn
-        |> log_in_user(user)
-        |> live("/authors/#{author.id}/edit")
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/authors/#{author.id}/edit")
       end
     end
 
@@ -225,11 +221,10 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
 
     test "can't be accessed by regular user", %{conn: conn, user: user, publisher: publisher} do
       for user <- [nil, user] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
-
-        conn
-        |> log_in_user(user)
-        |> live("/publishers/#{publisher.id}")
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/publishers/#{publisher.id}")
       end
     end
 
@@ -253,11 +248,10 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
   describe "Publisher Edit /publishers/:id/new" do
     test "can't be accessed by regular user", %{conn: conn, user: user} do
       for user <- [nil, user] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
-
-        conn
-        |> log_in_user(user)
-        |> live("/publishers/new")
+        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
+          conn
+          |> log_in_user(user)
+          |> live("/publishers/new")
       end
     end
 
@@ -284,11 +278,10 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
 
     test "can't be accessed by regular user", %{conn: conn, user: user, publisher: publisher} do
       for user <- [nil, user] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
-
-        conn
-        |> log_in_user(user)
-        |> live("/publishers/#{publisher.id}/edit")
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/publishers/#{publisher.id}/edit")
       end
     end
 
@@ -347,11 +340,10 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
       server: server
     } do
       for user <- [nil, user, moderator] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
-
-        conn
-        |> log_in_user(user)
-        |> live("/servers/#{server.id}")
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/servers/#{server.id}")
       end
     end
 
@@ -370,11 +362,10 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
   describe "Server Edit /servers/:id/new" do
     test "can't be accessed by non-admin user", %{conn: conn, user: user, moderator: moderator} do
       for user <- [nil, user, moderator] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
-
-        conn
-        |> log_in_user(user)
-        |> live("/servers/new")
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/servers/new")
       end
     end
 
@@ -402,11 +393,10 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
       server: server
     } do
       for user <- [nil, user, moderator] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
-
-        conn
-        |> log_in_user(user)
-        |> live("/servers/#{server.id}/edit")
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/servers/#{server.id}/edit")
       end
     end
 
@@ -470,11 +460,10 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
       moderator: moderator
     } do
       for user <- [nil, regular_user, moderator] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
-
-        conn
-        |> log_in_user(user)
-        |> live("/users/#{regular_user.id}")
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/users/#{regular_user.id}")
       end
     end
 
@@ -497,11 +486,10 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
       moderator: moderator
     } do
       for user <- [nil, regular_user, moderator] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
-
-        conn
-        |> log_in_user(user)
-        |> live("/users/#{regular_user.id}/edit")
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
+                 conn
+                 |> log_in_user(user)
+                 |> live("/users/#{regular_user.id}/edit")
       end
     end