From 135f4c0c93a7548da4f32e40f55d2107af0a3158 Mon Sep 17 00:00:00 2001
From: KKlochko <KKlochko@protonmail.com>
Date: Wed, 16 Aug 2023 18:12:29 +0300
Subject: [PATCH] Refactor the Company and its validator test.

---
 .../Controllers/API/v2/CartController.php     |  2 +-
 app/Models/Company.php                        |  4 +--
 .../Validation/CompanyValidationTest.php      | 35 +++++++++++++++++++
 3 files changed, 38 insertions(+), 3 deletions(-)
 create mode 100644 tests/Feature/Validation/CompanyValidationTest.php

diff --git a/app/Http/Controllers/API/v2/CartController.php b/app/Http/Controllers/API/v2/CartController.php
index d193cbf..66a75ad 100644
--- a/app/Http/Controllers/API/v2/CartController.php
+++ b/app/Http/Controllers/API/v2/CartController.php
@@ -165,7 +165,7 @@ class CartController extends Controller
             return response()->json($validation);
 
         // check for not valid company
-        $validation = Company::validate_with_name($companyName);
+        $validation = Company::validateWithName($companyName);
         if(array_key_exists('error', $validation))
             return response()->json($validation);
 
diff --git a/app/Models/Company.php b/app/Models/Company.php
index f7c35f1..7c89086 100644
--- a/app/Models/Company.php
+++ b/app/Models/Company.php
@@ -35,7 +35,7 @@ class Company extends Model
         return $count != 0;
     }
 
-    public static function validate_with_name(string $name)
+    public static function validateWithName(string $name)
     {
         $name = $name ?? '';
 
@@ -44,7 +44,7 @@ class Company extends Model
                 'error' => 'The company name is empty, please, write the name!!!'
             ];
 
-        $company = company::where('name', $name)->first();
+        $company = Company::where('name', $name)->first();
 
         if(!$company)
             return [
diff --git a/tests/Feature/Validation/CompanyValidationTest.php b/tests/Feature/Validation/CompanyValidationTest.php
new file mode 100644
index 0000000..00dfd06
--- /dev/null
+++ b/tests/Feature/Validation/CompanyValidationTest.php
@@ -0,0 +1,35 @@
+<?php
+
+namespace Tests\Feature;
+
+use Tests\TestCase;
+
+use App\Models\Company;
+
+class CompanyValidationTest extends TestCase
+{
+    public function testCompanyWithEmptyName(): void
+    {
+        $json = Company::validateWithName('');
+
+        $this->assertEquals($json['error'], 'The company name is empty, please, write the name!!!');
+    }
+
+    public function testNotExistingCompanyWithName(): void
+    {
+        $name = '404 Company';
+
+        $json = Company::validateWithName($name);
+
+        $this->assertEquals($json['error'], 'A company with the name does not exist!!!');
+    }
+
+    public function testValidCompanyWithName(): void
+    {
+        $name = 'testCompany';
+
+        $json = Company::validateWithName($name);
+
+        $this->assertEquals($json['ok'], 'A company with the name is valid.');
+    }
+}