Refactor the Links module.

This commit is contained in:
2023-08-02 21:20:01 +03:00
parent dd0e79c400
commit c6236c0ef1
5 changed files with 31 additions and 29 deletions
@@ -1,13 +1,13 @@
defmodule LinkShortenerWeb.Api.V1.LinkController do
use LinkShortenerWeb, :controller
alias LinkShortener.Links.Links
alias LinkShortener.Links
alias LinkShortener.Links.Link
action_fallback LinkShortenerWeb.FallbackController
def index(conn, _params) do
links = Links.get_all({})
links = Links.get_all()
render(conn, "index.json", links: links)
end
@@ -21,12 +21,12 @@ defmodule LinkShortenerWeb.Api.V1.LinkController do
end
def show(conn, %{"id" => id}) do
link = Links.get_one(id)
link = Links.get_one!(id)
render(conn, "show.json", link: link)
end
def update(conn, %{"id" => id, "link" => link_params}) do
link = Links.get_one(id)
link = Links.get_one!(id)
with {:ok, %Link{} = link} <- Links.update_one(link, link_params) do
render(conn, "show.json", link: link)
@@ -34,7 +34,7 @@ defmodule LinkShortenerWeb.Api.V1.LinkController do
end
def delete(conn, %{"id" => id}) do
link = Links.get_one(id)
link = Links.get_one!(id)
with {:ok, %Link{}} <- Links.delete_one(link) do
send_resp(conn, :no_content, "")