diff --git a/CHANGELOG.org b/CHANGELOG.org index 3bfc343..41fbf7c 100644 --- a/CHANGELOG.org +++ b/CHANGELOG.org @@ -46,3 +46,4 @@ ** 0.5.1 <2023-08-04 Fri> Add a generator for Link with random shorten. + Update Links.create_one to use a function. diff --git a/lib/link_shortener/links/links.ex b/lib/link_shortener/links/links.ex index 1092aac..e5b301a 100644 --- a/lib/link_shortener/links/links.ex +++ b/lib/link_shortener/links/links.ex @@ -4,13 +4,12 @@ defmodule LinkShortener.Links do import Ecto.Query alias LinkShortener.Repo alias LinkShortener.Links.Link - alias LinkShortener.Generators.SafeString + alias LinkShortener.Generators.LinkWithRandomShorten, as: LinkGenerator def new_one(), do: Link.changeset(%Link{}, %{}) - def create_one(attrs, length \\ 10, generator \\ SafeString) do - shorten = generator.generate(length) - Map.put(attrs, :shorten, shorten) + def create_one(attrs, length \\ 10, generator \\ &LinkGenerator.generate_one/2) do + generator.(attrs, length) |> insert_one() end