Update tests to add missing assert and = which check permission for LiveViews.

test/decentralised_book_index_web/live/live_views_permission_test.exs

@@ -47,8 +47,7 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
   describe "Book Edit /books/:id/new" do
     test "can't be accessed by regular user", %{conn: conn, user: user} do
       for user <- [nil, user] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
-
                  conn
                  |> log_in_user(user)
                  |> live("/books/new")
@@ -78,8 +77,7 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
 
     test "can't be accessed by regular user", %{conn: conn, user: user, book: book} do
       for user <- [nil, user] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
-
                  conn
                  |> log_in_user(user)
                  |> live("/books/#{book.id}/edit")
@@ -136,8 +134,7 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
   describe "Author Edit /authors/:id/new" do
     test "can't be accessed by regular user", %{conn: conn, user: user} do
       for user <- [nil, user] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
-
                  conn
                  |> log_in_user(user)
                  |> live("/authors/new")
@@ -167,8 +164,7 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
 
     test "can't be accessed by regular user", %{conn: conn, user: user, author: author} do
       for user <- [nil, user] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
-
                  conn
                  |> log_in_user(user)
                  |> live("/authors/#{author.id}/edit")
@@ -225,8 +221,7 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
 
     test "can't be accessed by regular user", %{conn: conn, user: user, publisher: publisher} do
       for user <- [nil, user] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
-
                  conn
                  |> log_in_user(user)
                  |> live("/publishers/#{publisher.id}")
@@ -253,8 +248,7 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
   describe "Publisher Edit /publishers/:id/new" do
     test "can't be accessed by regular user", %{conn: conn, user: user} do
       for user <- [nil, user] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
+        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
-
           conn
           |> log_in_user(user)
           |> live("/publishers/new")
@@ -284,8 +278,7 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
 
     test "can't be accessed by regular user", %{conn: conn, user: user, publisher: publisher} do
       for user <- [nil, user] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
-
                  conn
                  |> log_in_user(user)
                  |> live("/publishers/#{publisher.id}/edit")
@@ -347,8 +340,7 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
       server: server
     } do
       for user <- [nil, user, moderator] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
-
                  conn
                  |> log_in_user(user)
                  |> live("/servers/#{server.id}")
@@ -370,8 +362,7 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
   describe "Server Edit /servers/:id/new" do
     test "can't be accessed by non-admin user", %{conn: conn, user: user, moderator: moderator} do
       for user <- [nil, user, moderator] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
-
                  conn
                  |> log_in_user(user)
                  |> live("/servers/new")
@@ -402,8 +393,7 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
       server: server
     } do
       for user <- [nil, user, moderator] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
-
                  conn
                  |> log_in_user(user)
                  |> live("/servers/#{server.id}/edit")
@@ -470,8 +460,7 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
       moderator: moderator
     } do
       for user <- [nil, regular_user, moderator] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
-
                  conn
                  |> log_in_user(user)
                  |> live("/users/#{regular_user.id}")
@@ -497,8 +486,7 @@ defmodule DecentralisedBookIndexWeb.LiveViewsPermissionsTest do
       moderator: moderator
     } do
       for user <- [nil, regular_user, moderator] do
-        {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}}
+        assert {:error, {:redirect, %{flash: %{"error" => "Unauthorized!"}, to: "/"}}} =
-
                  conn
                  |> log_in_user(user)
                  |> live("/users/#{regular_user.id}/edit")